Skip to content

Add Citrea And Ink Chains#32

Merged
hanzel98 merged 4 commits into
mainfrom
chore/added-new-chains
Jul 30, 2025
Merged

Add Citrea And Ink Chains#32
hanzel98 merged 4 commits into
mainfrom
chore/added-new-chains

Conversation

@hanzel98

@hanzel98 hanzel98 commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

📝 Description

  • Included the chain configurations for:
    • Citrea testnet
    • Ink Mainnet and Testnet
  • Updated Etherscan explorer URLs
  • Updated Infura RPCs

🔄 What Changed?

List the specific changes made:

  • New configurations for the Citrea and Ink chains.
  • Added a change to fix the test of the active chains.

🚀 Why?

Explain the motivation behind these changes:

  • New chains were deployed
  • The test for the chains was failing

🧪 How to Test?

Describe how to test these changes:

  • Manual testing steps:
  1. Run the yarn validate-latest-contracts command inside packages/delegation-deployments
  • Automated tests added/updated
  • All existing tests pass

⚠️ Breaking Changes

List any breaking changes:

  • No breaking changes

📋 Checklist

Check off completed items:

  • Code follows the project's coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated
  • Changelog updated (if needed)
  • All CI checks pass

🔗 Related Issues

Link to related issues:
Closes # https://app.zenhub.com/workspaces/readable-permissions-67982ce51eb4360029b2c1a1/issues/gh/metamask/delegator-readable-permissions/252

📚 Additional Notes

Testing version 1.3.0

OP Mainnet succeeded
BNB Smart Chain succeeded
Polygon succeeded
Binance Smart Chain Testnet succeeded
Citrea Testnet succeeded
Unichain succeeded
Base succeeded
Gnosis succeeded
Arbitrum Nova succeeded
Unichain Sepolia succeeded
Arbitrum One succeeded
Linea Mainnet succeeded
Polygon Amoy succeeded
Arbitrum Sepolia succeeded
Base Sepolia succeeded
Linea Sepolia Testnet succeeded
Gnosis Chiado succeeded
Monad Testnet succeeded
Berachain Bepolia succeeded
Berachain succeeded
OP Sepolia succeeded
Sepolia succeeded
MegaEth Testnet succeeded
Ink Mainnet succeeded
Ink Sepolia succeeded
Ethereum succeeded


Successfully validated contract deployments

@hanzel98 hanzel98 requested a review from a team as a code owner July 10, 2025 14:51
@hanzel98 hanzel98 self-assigned this Jul 10, 2025
@hanzel98 hanzel98 requested review from MoMannn and jeffsmale90 July 10, 2025 16:58
jeffsmale90
jeffsmale90 previously approved these changes Jul 10, 2025

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to leave those files and remove them separately, or remove them here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn, I think this file can actually go away. We no longer run this validation as an automated test, because it was causing too many false positives.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted it

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can go away too - and it's corresponding tests.

This used to be part of the public API, before we cleaned it up, and was implemented to support an experiment.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted it

@jeffsmale90 jeffsmale90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 Boom!

@hanzel98 hanzel98 merged commit 9c62033 into main Jul 30, 2025
16 checks passed
@hanzel98 hanzel98 deleted the chore/added-new-chains branch July 30, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants