Add Citrea And Ink Chains#32
Merged
Merged
Conversation
jeffsmale90
previously approved these changes
Jul 10, 2025
jeffsmale90
left a comment
Collaborator
There was a problem hiding this comment.
Feel free to leave those files and remove them separately, or remove them here.
Collaborator
There was a problem hiding this comment.
Oh damn, I think this file can actually go away. We no longer run this validation as an automated test, because it was causing too many false positives.
Collaborator
There was a problem hiding this comment.
I think this can go away too - and it's corresponding tests.
This used to be part of the public API, before we cleaned it up, and was implemented to support an experiment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔄 What Changed?
List the specific changes made:
🚀 Why?
Explain the motivation behind these changes:
🧪 How to Test?
Describe how to test these changes:
yarn validate-latest-contractscommand inside packages/delegation-deploymentsList any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes # https://app.zenhub.com/workspaces/readable-permissions-67982ce51eb4360029b2c1a1/issues/gh/metamask/delegator-readable-permissions/252
📚 Additional Notes